Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

account for the extremely helpful and intuitive npm behaviour #1167

Merged
merged 1 commit into from
Apr 22, 2021
Merged

account for the extremely helpful and intuitive npm behaviour #1167

merged 1 commit into from
Apr 22, 2021

Conversation

Rich-Harris
Copy link
Member

fixes #1159

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Conduitry
Copy link
Member

I'm a little perplexed as to why this npm behavior matters. Shouldn't the published package not have any .gitignores in it all, and instead have JSON files containing the names and contents of the files to write?

@Rich-Harris
Copy link
Member Author

I realised that was causing a fair bit of duplication, which was quite costly when applied to the base64-encoded assets (i.e. the welcome image), and moved stuff that isn't variant-specific (i.e. components and .ts/.js files) back to the filesystem

@Conduitry
Copy link
Member

I see, makes sense, thanks.

@Rich-Harris Rich-Harris merged commit 2bf4338 into master Apr 22, 2021
@Rich-Harris Rich-Harris deleted the template-gitignore branch April 22, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include .gitignore in blank template
2 participants
@Rich-Harris @Conduitry